0508690d5a
Scoped API keys (P1): migrate 58 admin endpoints from require_admin to
require_scope so ks_ keys with Read-only/License-issuer/Support/Full-admin roles
work as intended. 12 sensitive endpoints stay master-key-only (issuer key,
provider connect/disconnect, web password, api-key CRUD, db-info, operator-name,
per-license tier change). require_scope is re-exported from api::admin so both
auth gates import from one place. Adds role-boundary tests.
Settle-amount tripwire (P1): get_invoice_status now returns
ProviderInvoiceSnapshot { status, amount }. On a confirmed settle,
audit_settle_amount (shared by the webhook and reconcile issue paths) compares
the provider-reported sat amount against the invoice's amount_sats and, on drift,
logs a warning + writes an invoice.amount_mismatch audit row, then issues anyway.
Advisory by design: a hard gate would fight an operator's BTCPay payment
tolerance, and Settled already implies paid-in-full. SAT-only — skips non-SAT
settles (fiat subscription renewals) and unparseable amounts.
401 lines
15 KiB
Rust
401 lines
15 KiB
Rust
//! Payment-provider abstraction.
|
|
//!
|
|
//! Today there's exactly one provider, BTCPay. v0.3 adds Zaprite. The
|
|
//! daemon stores the active provider as a trait object so adding new
|
|
//! providers is a single-impl drop-in.
|
|
//!
|
|
//! ## Why a trait
|
|
//!
|
|
//! Pre-v0.2 the daemon hard-coded BTCPay assumptions in `webhook.rs`,
|
|
//! `purchase.rs`, `reconcile.rs`, and `tipping.rs`. Adding Zaprite would
|
|
//! have meant either parallel code paths (gross) or post-hoc retrofitting
|
|
//! (worse). The `PaymentProvider` trait is a one-time refactor that lets
|
|
//! every later provider slot in cleanly.
|
|
//!
|
|
//! ## Trait surface
|
|
//!
|
|
//! Just the operations the rest of the daemon actually needs:
|
|
//!
|
|
//! - `kind()` — provider identity, for logs / audit / admin UI
|
|
//! - `create_invoice` — make a hosted-checkout session, return a URL
|
|
//! - `get_invoice_status` — authoritative status + amount, for the reconcile
|
|
//! loop (webhook misses) and the webhook settle-confirmation gate
|
|
//! - `validate_webhook` — provider-specific signature scheme + parse
|
|
//! - `pay_lightning_invoice` — for the tip-recipient flow; default impl
|
|
//! returns a "not supported" error so providers without a Lightning
|
|
//! payout capability can stay silent.
|
|
//!
|
|
//! ## What stays out of the trait
|
|
//!
|
|
//! Provider-specific setup (OAuth-style consent flows, webhook
|
|
//! registration, store enumeration) lives in provider-specific modules
|
|
//! like `api::btcpay_authorize`. Those modules are responsible for
|
|
//! constructing a provider impl and handing it to
|
|
//! `AppState::set_payment_provider`.
|
|
|
|
use anyhow::Result;
|
|
use axum::http::HeaderMap;
|
|
use serde::{Deserialize, Serialize};
|
|
use std::any::Any;
|
|
|
|
pub mod btcpay;
|
|
pub mod zaprite;
|
|
|
|
// =========================================================================
|
|
// Legacy compatibility shims — DEPRECATED, will be removed once all call
|
|
// sites migrate to the merchant-profile-aware resolution layer.
|
|
// =========================================================================
|
|
//
|
|
// During the multi-provider transition the singleton-config-and-active-
|
|
// provider-preference helpers stay callable so the existing connect flows
|
|
// (`btcpay_authorize.rs`, `zaprite_authorize.rs`) and the boot loader in
|
|
// `main.rs` keep working. Each shim wraps the new schema with the old
|
|
// semantics: `read_active_provider_preference` looks up the first provider
|
|
// attached to the default merchant profile and returns its kind;
|
|
// `write_active_provider_preference` is a no-op (the new model doesn't
|
|
// track an "active provider" preference — providers attach to profiles,
|
|
// profiles attach to products).
|
|
|
|
#[deprecated(
|
|
note = "use merchant-profile-aware resolution: \
|
|
state.payment_provider_for(product_id, rail)"
|
|
)]
|
|
pub const SETTING_ACTIVE_PROVIDER: &str = "active_payment_provider";
|
|
|
|
#[deprecated(
|
|
note = "look up providers via list_payment_providers_for_profile or \
|
|
payment_provider_by_id on AppState"
|
|
)]
|
|
pub async fn read_active_provider_preference(
|
|
pool: &sqlx::SqlitePool,
|
|
) -> Option<ProviderKind> {
|
|
// Post-migration: derive from the first provider attached to the
|
|
// default merchant profile (deterministic by connected_at ASC).
|
|
// Pre-migration (if the migration hasn't run yet on this DB):
|
|
// fall back to the legacy settings-table read.
|
|
let default_profile = crate::db::repo::get_default_merchant_profile(pool).await.ok().flatten();
|
|
if let Some(profile) = default_profile {
|
|
if let Ok(rows) = crate::db::repo::list_payment_providers_for_profile(pool, &profile.id).await {
|
|
if let Some(first) = rows.first() {
|
|
return ProviderKind::parse(&first.kind);
|
|
}
|
|
}
|
|
}
|
|
// Legacy fallback for the pre-migration window.
|
|
match crate::db::repo::settings_get(pool, SETTING_ACTIVE_PROVIDER).await {
|
|
Ok(Some(s)) => ProviderKind::parse(&s),
|
|
_ => None,
|
|
}
|
|
}
|
|
|
|
#[deprecated(
|
|
note = "providers are now attached to merchant profiles, not implicitly active. \
|
|
This shim is a no-op; remove the call."
|
|
)]
|
|
pub async fn write_active_provider_preference(
|
|
_pool: &sqlx::SqlitePool,
|
|
_kind: ProviderKind,
|
|
) -> anyhow::Result<()> {
|
|
// No-op. In the multi-provider model there's no "active" preference
|
|
// to write — providers are looked up by id (per-product) or by profile.
|
|
Ok(())
|
|
}
|
|
|
|
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
|
|
#[serde(rename_all = "lowercase")]
|
|
pub enum ProviderKind {
|
|
Btcpay,
|
|
Zaprite,
|
|
}
|
|
|
|
impl ProviderKind {
|
|
pub fn as_str(&self) -> &'static str {
|
|
match self {
|
|
ProviderKind::Btcpay => "btcpay",
|
|
ProviderKind::Zaprite => "zaprite",
|
|
}
|
|
}
|
|
|
|
pub fn parse(s: &str) -> Option<Self> {
|
|
match s {
|
|
"btcpay" => Some(Self::Btcpay),
|
|
"zaprite" => Some(Self::Zaprite),
|
|
_ => None,
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Buyer-facing payment method. The buy page renders a picker over these
|
|
/// (when a merchant profile exposes more than one); the routing layer maps
|
|
/// the buyer's pick to a specific provider via the profile's attached
|
|
/// providers + optional `merchant_profile_rail_preferences` tie-breakers.
|
|
///
|
|
/// Rails-per-provider-kind are **inherent** (declared by each provider
|
|
/// impl's `served_rails()` trait method), not configurable per provider
|
|
/// row. BTCPay serves Lightning + OnChain. Zaprite serves Card +
|
|
/// Lightning + OnChain.
|
|
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
|
|
#[serde(rename_all = "lowercase")]
|
|
pub enum Rail {
|
|
Lightning,
|
|
Onchain,
|
|
Card,
|
|
}
|
|
|
|
impl Rail {
|
|
pub fn as_str(&self) -> &'static str {
|
|
match self {
|
|
Rail::Lightning => "lightning",
|
|
Rail::Onchain => "onchain",
|
|
Rail::Card => "card",
|
|
}
|
|
}
|
|
|
|
pub fn parse(s: &str) -> Option<Self> {
|
|
match s {
|
|
"lightning" => Some(Self::Lightning),
|
|
"onchain" | "on-chain" | "on_chain" => Some(Self::Onchain),
|
|
"card" => Some(Self::Card),
|
|
_ => None,
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Static rails served by a provider kind. Returned by
|
|
/// `PaymentProvider::served_rails()`; centralized here so callers that
|
|
/// just want to know "what does kind X support" (e.g., the admin UI's
|
|
/// connect-flow guidance) don't have to instantiate a provider.
|
|
pub fn rails_for_kind(kind: ProviderKind) -> Vec<Rail> {
|
|
match kind {
|
|
ProviderKind::Btcpay => vec![Rail::Lightning, Rail::Onchain],
|
|
ProviderKind::Zaprite => vec![Rail::Card, Rail::Lightning, Rail::Onchain],
|
|
}
|
|
}
|
|
|
|
/// Build a typed `PaymentProvider` trait object from a `payment_providers`
|
|
/// row. Dispatch on `kind`. Used by the AppState provider cache when
|
|
/// resolving by provider id.
|
|
pub fn build_provider(
|
|
row: &crate::db::repo::PaymentProviderRow,
|
|
public_base_url: Option<&str>,
|
|
) -> anyhow::Result<std::sync::Arc<dyn PaymentProvider>> {
|
|
use crate::btcpay::client::BtcpayClient;
|
|
use crate::payment::btcpay::BtcpayProvider;
|
|
use crate::payment::zaprite::{ZapriteClient, ZapriteProvider};
|
|
|
|
match ProviderKind::parse(&row.kind) {
|
|
Some(ProviderKind::Btcpay) => {
|
|
let store_id = row.store_id.as_deref().ok_or_else(|| {
|
|
anyhow::anyhow!("BTCPay provider row {} missing store_id", row.id)
|
|
})?;
|
|
let webhook_secret = row.webhook_secret.clone().unwrap_or_default();
|
|
let client = BtcpayClient::new(&row.base_url, &row.api_key, store_id);
|
|
let provider = BtcpayProvider::new(client, webhook_secret)
|
|
.with_public_base(public_base_url.map(|s| s.to_string()));
|
|
Ok(std::sync::Arc::new(provider))
|
|
}
|
|
Some(ProviderKind::Zaprite) => {
|
|
let client = ZapriteClient::new(row.base_url.clone(), row.api_key.clone());
|
|
Ok(std::sync::Arc::new(ZapriteProvider::new(client)))
|
|
}
|
|
None => Err(anyhow::anyhow!(
|
|
"unknown payment provider kind {:?} on row {}",
|
|
row.kind,
|
|
row.id
|
|
)),
|
|
}
|
|
}
|
|
|
|
/// A monetary amount + the unit it's denominated in.
|
|
///
|
|
/// We carry currency through the system because v0.3 adds USD/EUR for
|
|
/// card payments via Zaprite. v0.2 still emits everything as `SAT`
|
|
/// since BTCPay invoices are sat-denominated for our flow.
|
|
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
|
|
pub struct Money {
|
|
/// The currency code. ISO 4217 for fiat; `SAT` and `BTC` for Bitcoin.
|
|
pub currency: String,
|
|
/// The amount in the currency's smallest indivisible unit (sats for
|
|
/// BTC, cents for USD, etc.). Using i64 because integer math is
|
|
/// cheaper than decimals and we never need fractional sats.
|
|
pub amount: i64,
|
|
}
|
|
|
|
impl Money {
|
|
pub fn sats(amount: i64) -> Self {
|
|
Money {
|
|
currency: "SAT".to_string(),
|
|
amount,
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Inputs for `create_invoice`. Bundled into a struct so the trait
|
|
/// signature stays stable as we add fields.
|
|
pub struct CreateInvoiceParams<'a> {
|
|
pub amount: Money,
|
|
/// Where the buyer is sent after a successful payment. The provider
|
|
/// appends its own status fragments / query params as needed.
|
|
pub redirect_url: &'a str,
|
|
/// Arbitrary metadata pinned to the invoice on the provider's side.
|
|
/// Used by Keysat to round-trip its internal invoice id back through
|
|
/// webhook events (`metadata.orderId` for BTCPay; `externalOrderId`
|
|
/// for Zaprite).
|
|
pub metadata: serde_json::Value,
|
|
/// Keysat's internal invoice id (UUID). Passed back in webhook
|
|
/// events to correlate with the local row.
|
|
pub external_order_id: &'a str,
|
|
/// Buyer email if known. Some providers use this for receipts.
|
|
pub buyer_email: Option<&'a str>,
|
|
/// Ask the provider to prompt the buyer to save their payment
|
|
/// profile for future merchant-initiated charges. Zaprite honors
|
|
/// this for autopay-supporting rails (Stripe card, etc.); BTCPay
|
|
/// has no equivalent concept and silently ignores it. Set
|
|
/// `Some(true)` on the FIRST cycle of a recurring purchase so the
|
|
/// renewal worker can later call `charge_order_with_profile`
|
|
/// against the saved profile. `None` / `Some(false)` is the
|
|
/// one-shot default.
|
|
pub allow_save_payment_profile: Option<bool>,
|
|
}
|
|
|
|
/// Result of `create_invoice`. Whatever the provider returned, narrowed
|
|
/// to the two things the rest of Keysat actually needs.
|
|
#[derive(Debug, Clone)]
|
|
pub struct CreatedInvoiceHandle {
|
|
/// Provider-side invoice id. BTCPay invoice id today; Zaprite order
|
|
/// id later. Stored on the invoice row so we can reconcile.
|
|
pub provider_invoice_id: String,
|
|
/// Public URL the buyer is redirected to to pay.
|
|
pub checkout_url: String,
|
|
}
|
|
|
|
/// Provider-agnostic invoice status used by the reconcile loop. Maps to
|
|
/// the daemon's existing `InvoiceStatus` model but stays decoupled so
|
|
/// the trait doesn't pull in domain types.
|
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
|
pub enum ProviderInvoiceStatus {
|
|
Pending,
|
|
Settled,
|
|
Expired,
|
|
Refunded,
|
|
Invalid,
|
|
}
|
|
|
|
/// The provider's current view of an invoice: its `status` plus the amount
|
|
/// the provider has the invoice denominated for. Returned by
|
|
/// `PaymentProvider::get_invoice_status`.
|
|
///
|
|
/// `amount` is the price the provider has on record for the invoice (what we
|
|
/// asked it to charge), normalized to `SAT` when the provider used a Bitcoin
|
|
/// unit. It is `None` when the response carried no parseable amount/currency.
|
|
/// `status` is the load-bearing settle gate; `amount` feeds only the
|
|
/// **advisory** settle-amount tripwire in `api::webhook` / `reconcile` —
|
|
/// callers treat `None` as "no opinion" and MUST NOT gate issuance on it.
|
|
/// See docs/guides/payments.md.
|
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
|
pub struct ProviderInvoiceSnapshot {
|
|
pub status: ProviderInvoiceStatus,
|
|
pub amount: Option<Money>,
|
|
}
|
|
|
|
/// Parsed webhook event. Only the kinds Keysat actually acts on are
|
|
/// modeled; everything else falls into `Other` and is ignored.
|
|
#[derive(Debug, Clone)]
|
|
pub enum ProviderWebhookEvent {
|
|
InvoiceSettled {
|
|
provider_invoice_id: String,
|
|
},
|
|
InvoiceExpired {
|
|
provider_invoice_id: String,
|
|
},
|
|
InvoiceInvalid {
|
|
provider_invoice_id: String,
|
|
},
|
|
InvoiceRefunded {
|
|
provider_invoice_id: String,
|
|
refunded_amount: Option<Money>,
|
|
},
|
|
/// Anything else the provider sent. We log + 200 it so the provider
|
|
/// stops retrying.
|
|
Other {
|
|
kind: String,
|
|
provider_invoice_id: Option<String>,
|
|
},
|
|
}
|
|
|
|
impl ProviderWebhookEvent {
|
|
pub fn provider_invoice_id(&self) -> Option<&str> {
|
|
match self {
|
|
ProviderWebhookEvent::InvoiceSettled { provider_invoice_id }
|
|
| ProviderWebhookEvent::InvoiceExpired { provider_invoice_id }
|
|
| ProviderWebhookEvent::InvoiceInvalid { provider_invoice_id }
|
|
| ProviderWebhookEvent::InvoiceRefunded {
|
|
provider_invoice_id, ..
|
|
} => Some(provider_invoice_id),
|
|
ProviderWebhookEvent::Other {
|
|
provider_invoice_id,
|
|
..
|
|
} => provider_invoice_id.as_deref(),
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Result of paying a Lightning invoice via the provider's LN node.
|
|
#[derive(Debug, Clone)]
|
|
pub struct PaymentReceipt {
|
|
pub payment_hash: Option<String>,
|
|
/// Raw provider response, for the audit log.
|
|
pub raw: serde_json::Value,
|
|
}
|
|
|
|
/// The trait every payment provider implements.
|
|
///
|
|
/// Object-safe (uses `&dyn`/`Box<dyn>`) thanks to `#[async_trait]`. The
|
|
/// `Any` supertrait lets call sites that still need provider-specific
|
|
/// types (e.g., the BTCPay-specific authorize flow) downcast.
|
|
#[async_trait::async_trait]
|
|
pub trait PaymentProvider: Send + Sync + Any {
|
|
fn kind(&self) -> ProviderKind;
|
|
|
|
/// Payment rails this provider can settle. Default impl uses the
|
|
/// static `rails_for_kind()` mapping; impls only override if they
|
|
/// expose a non-default set (e.g., a degraded BTCPay configured
|
|
/// without Lightning support — not currently a Keysat concern).
|
|
fn served_rails(&self) -> Vec<Rail> {
|
|
rails_for_kind(self.kind())
|
|
}
|
|
|
|
async fn create_invoice(
|
|
&self,
|
|
params: CreateInvoiceParams<'_>,
|
|
) -> Result<CreatedInvoiceHandle>;
|
|
|
|
async fn get_invoice_status(
|
|
&self,
|
|
provider_invoice_id: &str,
|
|
) -> Result<ProviderInvoiceSnapshot>;
|
|
|
|
/// Verify and parse a webhook delivery. Implementations are
|
|
/// responsible for reading whatever signature header their provider
|
|
/// uses, computing the expected HMAC, and constant-time comparing.
|
|
fn validate_webhook(
|
|
&self,
|
|
headers: &HeaderMap,
|
|
body: &[u8],
|
|
) -> Result<ProviderWebhookEvent>;
|
|
|
|
/// Pay a BOLT11 Lightning invoice via the provider's LN node.
|
|
/// Default impl returns a "not supported" error so providers
|
|
/// without LN payout capability don't have to override.
|
|
async fn pay_lightning_invoice(&self, _bolt11: &str) -> Result<PaymentReceipt> {
|
|
anyhow::bail!(
|
|
"pay_lightning_invoice not supported by this payment provider"
|
|
)
|
|
}
|
|
|
|
/// Hatch for compat-era downcasting. Lets `AppState`'s legacy
|
|
/// `btcpay_client()` accessor reach the inner BTCPay-specific
|
|
/// client. v0.3 will retire the compat accessors and remove this.
|
|
fn as_any(&self) -> &dyn Any;
|
|
}
|