0.2.26: security hardening from audit (P2/P3 fixes)
Address the security-auditor findings the user selected (items 2, 3, 4): Default admin credentials (P2): remove the fixed `Ten31` default. First boot now generates a strong random admin password (secrets.token_urlsafe), records it 0600 at /data/.admin-password, and surfaces it once via a new "Show Initial Admin Password" StartOS action (CLI `show-admin-password`). The stored password is cleared when the admin is reset (CLI reset-password) or self-changes it (change-password endpoint). Login hardening (P2): add a per-IP in-memory sliding-window rate limiter (10 failures / 5 min -> 429 + Retry-After) in ratelimit.py; run a dummy argon2 verify when the user is unknown so timing can't enumerate usernames; keep a single generic 401 for unknown-user and wrong-password. Hardening (P3): server process now runs unprivileged -- Dockerfile adds uid 10001 appuser; start.sh (still root) chowns the mounted /data then drops via `setpriv` before exec'ing uvicorn. Spreadsheet imports are size-capped via storage.read_capped (413 past MAX_UPLOAD_SIZE) in the schedule, capital preview, and batch paths. batch_import no longer returns raw exception text (generic per-file messages). Verified in the packed amd64 container: PID1 uvicorn runs as uid 10001, /data owned 10001 with 0600 secrets; generated admin password retrievable via CLI and logs in (200); 11th bad login -> 429; admin reset clears the stored password. Tests: test_auth_hardening.py (4). Full suite 21 passed; frontend tsc + StartOS bundle clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
025aff4fac
commit
69f12b0519
@@ -34,6 +34,11 @@ RUN chmod +x ./start.sh
|
||||
# Data volume mount point
|
||||
RUN mkdir -p /data
|
||||
|
||||
# Unprivileged account for the server process. The container still starts as root (see start.sh)
|
||||
# so it can chown the platform-mounted /data volume, then drops to this uid via setpriv.
|
||||
RUN groupadd --gid 10001 appuser \
|
||||
&& useradd --uid 10001 --gid 10001 --no-create-home --shell /usr/sbin/nologin appuser
|
||||
|
||||
ENV TEN31_DB_PATH=/data/portal.db
|
||||
ENV TEN31_DOCS_DIR=/data/documents
|
||||
ENV TEN31_SESSION_SECRET=change-me
|
||||
|
||||
+1
-1
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "ten31portal-startos",
|
||||
"version": "0.2.25",
|
||||
"version": "0.2.26",
|
||||
"private": true,
|
||||
"scripts": {
|
||||
"build": "npm run check && rm -rf ./javascript && ncc build startos/index.ts -o ./javascript",
|
||||
|
||||
+34
-11
@@ -14,31 +14,54 @@ fi
|
||||
|
||||
# Create first approver on first boot if no users exist
|
||||
if [ ! -f /data/.initialized ]; then
|
||||
echo "First boot: running migrations and creating default approver..."
|
||||
echo "First boot: running migrations and creating the admin account..."
|
||||
|
||||
# Set default credentials (user can change via CLI later)
|
||||
ADMIN_NAME="${TEN31_ADMIN_NAME:-Jonathan}"
|
||||
ADMIN_USERNAME="${TEN31_ADMIN_USERNAME:-admin}"
|
||||
ADMIN_EMAIL="${TEN31_ADMIN_EMAIL:-jonathan@ten31.xyz}"
|
||||
ADMIN_PASSWORD="${TEN31_ADMIN_PASSWORD:-Ten31}"
|
||||
|
||||
python3 -m ten31portal.cli create-user \
|
||||
# No weak default: use an operator-supplied password if given, else generate a strong random
|
||||
# one and record it (0600) so it can be retrieved once via the "Show Initial Admin Password"
|
||||
# action. There is no fixed default credential to guess.
|
||||
ADMIN_PW_FILE="$(dirname "$TEN31_DB_PATH")/.admin-password"
|
||||
if [ -n "$TEN31_ADMIN_PASSWORD" ]; then
|
||||
ADMIN_PASSWORD="$TEN31_ADMIN_PASSWORD"
|
||||
GENERATED=""
|
||||
else
|
||||
ADMIN_PASSWORD="$(python3 -c "import secrets; print(secrets.token_urlsafe(18))")"
|
||||
GENERATED="yes"
|
||||
fi
|
||||
|
||||
if python3 -m ten31portal.cli create-user \
|
||||
--name "$ADMIN_NAME" \
|
||||
--username "$ADMIN_USERNAME" \
|
||||
--email "$ADMIN_EMAIL" \
|
||||
--role approver \
|
||||
--password "$ADMIN_PASSWORD" \
|
||||
--service-admin || true
|
||||
--service-admin; then
|
||||
if [ -n "$GENERATED" ]; then
|
||||
printf '%s' "$ADMIN_PASSWORD" > "$ADMIN_PW_FILE"
|
||||
chmod 600 "$ADMIN_PW_FILE"
|
||||
echo "Admin '$ADMIN_USERNAME' created with a generated password."
|
||||
echo " Retrieve it once via the 'Show Initial Admin Password' service action, then change it."
|
||||
else
|
||||
echo "Admin '$ADMIN_USERNAME' created with the operator-supplied password."
|
||||
fi
|
||||
fi
|
||||
|
||||
touch /data/.initialized
|
||||
echo "Default approver created: username=$ADMIN_USERNAME"
|
||||
fi
|
||||
|
||||
# Log level is overridable at runtime for debugging; defaults to info.
|
||||
LOG_LEVEL="${TEN31_LOG_LEVEL:-info}"
|
||||
|
||||
# Serve frontend static files from the backend
|
||||
exec uvicorn ten31portal.main:app \
|
||||
--host 0.0.0.0 \
|
||||
--port 8000 \
|
||||
--log-level "$LOG_LEVEL"
|
||||
# Hand off to the server as an unprivileged user. The platform mounts /data owned by root, so
|
||||
# (while still root) we take ownership of the data volume first, then drop privileges with
|
||||
# setpriv — the long-running server process is never root, limiting what a compromise can reach.
|
||||
if [ "$(id -u)" = "0" ]; then
|
||||
chown -R 10001:10001 /data
|
||||
exec setpriv --reuid=10001 --regid=10001 --clear-groups \
|
||||
uvicorn ten31portal.main:app --host 0.0.0.0 --port 8000 --log-level "$LOG_LEVEL"
|
||||
else
|
||||
exec uvicorn ten31portal.main:app --host 0.0.0.0 --port 8000 --log-level "$LOG_LEVEL"
|
||||
fi
|
||||
|
||||
@@ -214,6 +214,44 @@ const listUsersAction = Action.withoutInput(
|
||||
},
|
||||
)
|
||||
|
||||
// ============================================
|
||||
// Action: Show Initial Admin Password
|
||||
// ============================================
|
||||
const showAdminPasswordAction = Action.withoutInput(
|
||||
'show-admin-password',
|
||||
{
|
||||
name: 'Show Initial Admin Password',
|
||||
description:
|
||||
'Reveal the randomly-generated admin password created on first boot. Sign in with it, then change your password — after which this no longer shows it.',
|
||||
warning: null,
|
||||
allowedStatuses: 'only-running',
|
||||
group: null,
|
||||
visibility: 'enabled',
|
||||
},
|
||||
async ({ effects }) => {
|
||||
try {
|
||||
const result = await runCli(effects, ['show-admin-password'], 'show-admin-password-task')
|
||||
if (result.exitCode !== 0) {
|
||||
return errorResult(result.stderr?.toString() || 'Failed to read the admin password')
|
||||
}
|
||||
return {
|
||||
version: '1' as const,
|
||||
title: 'Initial Admin Password',
|
||||
message: 'Sign in as "admin" with this password, then change it from the portal.',
|
||||
result: {
|
||||
type: 'single' as const,
|
||||
value: (result.stdout?.toString() || '').trim() || 'No stored password.',
|
||||
copyable: true,
|
||||
qr: false,
|
||||
masked: true,
|
||||
},
|
||||
}
|
||||
} catch (e: any) {
|
||||
return errorResult(`Failed to read the admin password: ${e.message || e}`)
|
||||
}
|
||||
},
|
||||
)
|
||||
|
||||
// ============================================
|
||||
// Action: Delete User
|
||||
// ============================================
|
||||
@@ -379,6 +417,7 @@ const resetHoldingsAction = Action.withInput(
|
||||
export const actions = sdk.Actions.of()
|
||||
.addAction(createUserAction)
|
||||
.addAction(resetPasswordAction)
|
||||
.addAction(showAdminPasswordAction)
|
||||
.addAction(listUsersAction)
|
||||
.addAction(deleteUserAction)
|
||||
.addAction(dedupeAction)
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
export { v_0_2_25 as current } from './v_0_2_25'
|
||||
export { v_0_2_26 as current } from './v_0_2_26'
|
||||
import { v_0_1_0 } from './v_0_1_0'
|
||||
import { v_0_2_0 } from './v_0_2_0'
|
||||
import { v_0_2_1 } from './v_0_2_1'
|
||||
@@ -24,4 +24,5 @@ import { v_0_2_21 } from './v_0_2_21'
|
||||
import { v_0_2_22 } from './v_0_2_22'
|
||||
import { v_0_2_23 } from './v_0_2_23'
|
||||
import { v_0_2_24 } from './v_0_2_24'
|
||||
export const other = [v_0_1_0, v_0_2_0, v_0_2_1, v_0_2_3, v_0_2_4, v_0_2_5, v_0_2_6, v_0_2_7, v_0_2_8, v_0_2_9, v_0_2_10, v_0_2_11, v_0_2_12, v_0_2_13, v_0_2_14, v_0_2_15, v_0_2_16, v_0_2_17, v_0_2_18, v_0_2_19, v_0_2_20, v_0_2_21, v_0_2_22, v_0_2_23, v_0_2_24]
|
||||
import { v_0_2_25 } from './v_0_2_25'
|
||||
export const other = [v_0_1_0, v_0_2_0, v_0_2_1, v_0_2_3, v_0_2_4, v_0_2_5, v_0_2_6, v_0_2_7, v_0_2_8, v_0_2_9, v_0_2_10, v_0_2_11, v_0_2_12, v_0_2_13, v_0_2_14, v_0_2_15, v_0_2_16, v_0_2_17, v_0_2_18, v_0_2_19, v_0_2_20, v_0_2_21, v_0_2_22, v_0_2_23, v_0_2_24, v_0_2_25]
|
||||
|
||||
@@ -0,0 +1,13 @@
|
||||
import { VersionInfo } from '@start9labs/start-sdk'
|
||||
|
||||
export const v_0_2_26 = VersionInfo.of({
|
||||
version: '0.2.26:0',
|
||||
releaseNotes: {
|
||||
en_US:
|
||||
'Security hardening (from a full audit): no more fixed default admin password — first boot generates a strong random one, retrievable once via the new "Show Initial Admin Password" action and cleared after you change it. Login now rate-limits repeated failures and returns a single generic message (no username enumeration). The server process runs unprivileged (non-root). Spreadsheet imports are size-capped and batch import errors no longer leak internal details.',
|
||||
},
|
||||
migrations: {
|
||||
up: async ({ effects }) => {},
|
||||
down: async ({ effects }) => {},
|
||||
},
|
||||
})
|
||||
Reference in New Issue
Block a user