Implement adjudicated DO items across backend, frontend, deploy

From the ROADMAP adjudication (12 of 13 DO items; D2 is a commit action).

Backend:
- B3: pytest suite (auth, entity CRUD, rollup) + dev deps + pytest config
- B4: cap document uploads at TEN31_MAX_UPLOAD_SIZE (default 50MB), stream-
  checked with partial-file cleanup, 413 on overflow
- B7: type AuditLog.detail as dict|list|str|None to match the JSON column
- B10: index foreign-key columns (migration a7b8c9d0e1f2 + index=True)
- B11: cli delete-user logs file-removal errors instead of swallowing them

Frontend:
- F2: distinguish "server unreachable" from "logged out"; retry prompt
- F4: confirm before destructive holdings-replace on import; step progress
- F6: expandable audit-log detail with full JSON
- F7: empty-state on the Investments page
- F8: shared role helpers (WRITER_ROLES/canEditRound/isApprover), used by
  EntitiesList, AuditLog, Import, ValuationWorkflow

Deploy:
- D5: run tsc --noEmit before packaging (build script)
- D6: TEN31_LOG_LEVEL env var (defaults to info)

Verified: 8/8 backend tests pass; alembic upgrades to head with 13 FK
indexes; upload limit rejects oversized + cleans up; frontend tsc + vite
build clean; dev server serves and proxies to the API.
This commit is contained in:
Jonathan Kirkwood
2026-07-01 13:33:40 -05:00
parent 77eeb3bd7f
commit 8247c28243
22 changed files with 1757 additions and 465 deletions
+77
View File
@@ -0,0 +1,77 @@
"""Shared pytest fixtures: an in-memory DB and a FastAPI TestClient.
The client is created WITHOUT the context-manager form on purpose, so the app lifespan (which
runs real Alembic migrations against the configured DB_PATH) never fires. Tables come from
SQLModel.metadata.create_all against a throwaway in-memory database instead.
"""
import pytest
from fastapi.testclient import TestClient
from sqlalchemy.pool import StaticPool
from sqlmodel import Session, SQLModel, create_engine
import ten31portal.models # noqa: F401 — importing registers every table on SQLModel.metadata
from ten31portal.auth import hash_password
from ten31portal.database import get_session
from ten31portal.main import app
from ten31portal.models import User, UserRole
@pytest.fixture
def engine():
eng = create_engine(
"sqlite://",
connect_args={"check_same_thread": False},
poolclass=StaticPool, # one shared in-memory connection across sessions
)
SQLModel.metadata.create_all(eng)
yield eng
SQLModel.metadata.drop_all(eng)
@pytest.fixture
def session(engine):
with Session(engine) as s:
yield s
@pytest.fixture
def client(engine):
def override_get_session():
with Session(engine) as s:
yield s
app.dependency_overrides[get_session] = override_get_session
yield TestClient(app)
app.dependency_overrides.clear()
def make_user(session, *, username="admin", password="password123",
role=UserRole.approver, name="Test User", email=None, **kwargs):
user = User(
name=name,
username=username,
email=email,
password_hash=hash_password(password),
role=role,
**kwargs,
)
session.add(user)
session.commit()
session.refresh(user)
return user
@pytest.fixture
def approver(session):
return make_user(session, username="approver", role=UserRole.approver)
@pytest.fixture
def auth_client(client, approver):
"""A TestClient already logged in as an approver (a writer)."""
resp = client.post(
"/api/auth/login", json={"login": "approver", "password": "password123"}
)
assert resp.status_code == 200, resp.text
return client