From the ROADMAP adjudication (12 of 13 DO items; D2 is a commit action). Backend: - B3: pytest suite (auth, entity CRUD, rollup) + dev deps + pytest config - B4: cap document uploads at TEN31_MAX_UPLOAD_SIZE (default 50MB), stream- checked with partial-file cleanup, 413 on overflow - B7: type AuditLog.detail as dict|list|str|None to match the JSON column - B10: index foreign-key columns (migration a7b8c9d0e1f2 + index=True) - B11: cli delete-user logs file-removal errors instead of swallowing them Frontend: - F2: distinguish "server unreachable" from "logged out"; retry prompt - F4: confirm before destructive holdings-replace on import; step progress - F6: expandable audit-log detail with full JSON - F7: empty-state on the Investments page - F8: shared role helpers (WRITER_ROLES/canEditRound/isApprover), used by EntitiesList, AuditLog, Import, ValuationWorkflow Deploy: - D5: run tsc --noEmit before packaging (build script) - D6: TEN31_LOG_LEVEL env var (defaults to info) Verified: 8/8 backend tests pass; alembic upgrades to head with 13 FK indexes; upload limit rejects oversized + cleans up; frontend tsc + vite build clean; dev server serves and proxies to the API.
157 lines
5.7 KiB
Python
157 lines
5.7 KiB
Python
"""Document upload, listing, download, and deletion with per-account access control."""
|
|
|
|
from fastapi import APIRouter, Depends, File, Form, HTTPException, UploadFile
|
|
from fastapi.responses import FileResponse
|
|
from sqlmodel import Session, select
|
|
|
|
from ten31portal.audit import record_audit
|
|
from ten31portal.auth import (
|
|
accessible_entity_ids, can_access_entity, get_current_user,
|
|
household_user_ids, require_internal_admin,
|
|
)
|
|
from ten31portal.database import get_session
|
|
from ten31portal.models import (
|
|
Document, DocumentCategory, Entity, User, UserRole,
|
|
)
|
|
from ten31portal.schemas import DocumentResponse
|
|
from ten31portal import storage
|
|
|
|
router = APIRouter(prefix="/api/documents", tags=["documents"])
|
|
|
|
|
|
def _can_upload(user: User, entity_id: int, session: Session) -> bool:
|
|
"""Internal admins upload anywhere; external fund admins upload for their entities."""
|
|
if user.role in (UserRole.approver, UserRole.cfo, UserRole.operations):
|
|
return True
|
|
if user.role == UserRole.fund_administrator:
|
|
return can_access_entity(user, entity_id, session)
|
|
return False
|
|
|
|
|
|
def _can_view(user: User, doc: Document, session: Session) -> bool:
|
|
allowed = accessible_entity_ids(user, session)
|
|
if allowed is None: # internal staff
|
|
return True
|
|
if doc.entity_id not in allowed:
|
|
return False
|
|
# Investors only see shared docs or those addressed to any of their linked names;
|
|
# fund admins see all docs for the entity.
|
|
if user.role == UserRole.investor:
|
|
return (
|
|
doc.investor_user_id is None
|
|
or doc.investor_user_id in household_user_ids(user, session)
|
|
)
|
|
return True
|
|
|
|
|
|
@router.get("")
|
|
def list_documents(
|
|
entity_id: int | None = None,
|
|
investor_user_id: int | None = None,
|
|
user: User = Depends(get_current_user),
|
|
session: Session = Depends(get_session),
|
|
) -> list[DocumentResponse]:
|
|
query = select(Document)
|
|
if entity_id is not None:
|
|
query = query.where(Document.entity_id == entity_id)
|
|
if investor_user_id is not None:
|
|
query = query.where(Document.investor_user_id == investor_user_id)
|
|
rows = session.exec(query.order_by(Document.created_at.desc())).all() # type: ignore[union-attr]
|
|
visible = [d for d in rows if _can_view(user, d, session)]
|
|
return [DocumentResponse.model_validate(d, from_attributes=True) for d in visible]
|
|
|
|
|
|
@router.post("", status_code=201)
|
|
def upload_document(
|
|
entity_id: int = Form(...),
|
|
category: DocumentCategory = Form(DocumentCategory.other),
|
|
title: str | None = Form(None),
|
|
investor_user_id: int | None = Form(None),
|
|
file: UploadFile = File(...),
|
|
user: User = Depends(get_current_user),
|
|
session: Session = Depends(get_session),
|
|
) -> DocumentResponse:
|
|
entity = session.get(Entity, entity_id)
|
|
if entity is None:
|
|
raise HTTPException(status_code=404, detail="Entity not found")
|
|
if not _can_upload(user, entity_id, session):
|
|
raise HTTPException(status_code=403, detail="Insufficient permissions")
|
|
|
|
# If targeting a specific investor, they must have access to this entity.
|
|
if investor_user_id is not None:
|
|
target = session.get(User, investor_user_id)
|
|
if target is None:
|
|
raise HTTPException(status_code=404, detail="Investor not found")
|
|
if not can_access_entity(target, entity_id, session):
|
|
raise HTTPException(
|
|
status_code=400,
|
|
detail="That investor does not have access to this entity.",
|
|
)
|
|
|
|
try:
|
|
storage_name, size = storage.save_upload(file)
|
|
except storage.UploadTooLarge as exc:
|
|
raise HTTPException(status_code=413, detail=str(exc))
|
|
doc = Document(
|
|
entity_id=entity_id,
|
|
investor_user_id=investor_user_id,
|
|
category=category,
|
|
title=title or (file.filename or "Untitled"),
|
|
original_filename=file.filename or storage_name,
|
|
content_type=file.content_type or "application/octet-stream",
|
|
size_bytes=size,
|
|
storage_path=storage_name,
|
|
uploaded_by=user.id,
|
|
)
|
|
session.add(doc)
|
|
session.flush()
|
|
record_audit(session, user.id, "upload", "document", doc.id, {
|
|
"entity_id": entity_id,
|
|
"investor_user_id": investor_user_id,
|
|
"category": category.value,
|
|
"filename": doc.original_filename,
|
|
})
|
|
session.commit()
|
|
session.refresh(doc)
|
|
return DocumentResponse.model_validate(doc, from_attributes=True)
|
|
|
|
|
|
@router.get("/{document_id}/download")
|
|
def download_document(
|
|
document_id: int,
|
|
user: User = Depends(get_current_user),
|
|
session: Session = Depends(get_session),
|
|
) -> FileResponse:
|
|
doc = session.get(Document, document_id)
|
|
if doc is None or not _can_view(user, doc, session):
|
|
raise HTTPException(status_code=404, detail="Document not found")
|
|
try:
|
|
path = storage.full_path(doc.storage_path)
|
|
except ValueError:
|
|
raise HTTPException(status_code=404, detail="Document not found")
|
|
if not path.is_file():
|
|
raise HTTPException(status_code=404, detail="File missing on disk")
|
|
return FileResponse(
|
|
path,
|
|
media_type=doc.content_type,
|
|
filename=doc.original_filename,
|
|
)
|
|
|
|
|
|
@router.delete("/{document_id}")
|
|
def delete_document(
|
|
document_id: int,
|
|
admin: User = Depends(require_internal_admin),
|
|
session: Session = Depends(get_session),
|
|
) -> dict[str, str]:
|
|
doc = session.get(Document, document_id)
|
|
if doc is None:
|
|
raise HTTPException(status_code=404, detail="Document not found")
|
|
storage.delete_file(doc.storage_path)
|
|
record_audit(session, admin.id, "delete", "document", document_id, {
|
|
"filename": doc.original_filename,
|
|
})
|
|
session.delete(doc)
|
|
session.commit()
|
|
return {"status": "deleted"}
|