grant/standards
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Capture: keysat refactor-scout test-drive findings (4 items)

Browse Source
This commit is contained in:
Keysat
2026-06-19 22:57:52 -05:00
parent f258f9fd3c
commit ccae956ccb
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
INBOX.md
+4
View File
@@ -52,3 +52,7 @@ Example:
- [ ] (spark-control) [feature][P2] Add a dashboard card for the ten31 CRM / intake bot (Update/Restart/Stop/Logs tile like matrix-bridge) — confirm whether already done; see ten31-database docs/handoffs/add-intake-bot-to-spark-control.md, 2026-06-18
- [ ] (proof-of-work) [feature][P2] brainstorm better tracking of cardio logging and cardio program planning (in-week variety and long term programs) — via matrix, 2026-06-19
- [ ] (matrix-bridge) [bug][P2] what are the open brackets when you log an inbox item through matrix, eg “📥 captured → - [ ] (proof-of-work) [feature][P2] brainstorm better tracking of cardio logging and cardio program planning (in-week variety and long term programs) — via matrix, 2026-06-19” — via matrix, 2026-06-19
- [ ] (keysat) [bug][P2] licensing-service buy page under-escapes HTML — buy_page.rs html_escape (licensing-service/src/api/buy_page.rs:1536) omits the single-quote escape that the canonical copy (api/mod.rs:1175) has; the buyer-facing page renders operator/product/discount-code text into HTML attributes. Fix: dedupe both copies onto the mod.rs impl (the correct one) + add a single-quote test. From refactor-scout test drive, 2026-06-19
- [ ] (keysat) [chore][P3] Delete 3 confirmed-dead functions in licensing-service (clippy + grep confirm zero callers): deprecated payment shims read_/write_active_provider_preference (src/payment/mod.rs:59-102), unwired _audit_payload (src/upgrades.rs:607), unused BtcpayClient::store_id (src/btcpay/client.rs:172). From refactor-scout test drive, 2026-06-19
- [ ] (keysat) [chore][P3] licensing-service db/repo.rs — extract PRODUCT_COLS (lines 17-46, repeated 4×) and INVOICE_COLS (516-518, 2×) named consts to match the *_COLS convention every other entity already uses; test-covered by tests/api.rs so low risk. From refactor-scout test drive, 2026-06-19
- [ ] (keysat) [chore][P3] licensing-service refactor candidates — DEFER, each gated on writing characterization tests FIRST: split buy_page::render() (1070 lines, src/api/buy_page.rs:35), subscriptions::renew_one() (370 lines, money-critical worker), and the db/repo.rs god module (3422 lines, split along its existing section-comment headers). From refactor-scout test drive, 2026-06-19